feat: foo20 check an error from grc20 package #977
Conversation
github-actions
bot
added
the
🧾 package/realm
|
Related with #952 |
|
|
||
| func TestErrConditions(t *testing.T) { | ||
| admin := std.Address("g1us8428u2a5satrlxzagqqa5m6vmuze025anjlj") | ||
| empty := std.Address("") |
There was a problem hiding this comment.
Maybe add another case?
invalid := std.Address("invalid")There was a problem hiding this comment.
grc20 package uses checkIsValidAddress to check whether address is valid or not.
gno/examples/gno.land/p/demo/grc/grc20/util.gno
Lines 7 to 12 in 973be98
unfortunately it only checks addr.String() == "", so that invalid won't be invalid but valid.
There was a problem hiding this comment.
perhaps better to rename above function to checkIsEmptyAddress
There was a problem hiding this comment.
Ethereum ecosystem libs like Ethers and web3.js commonly utilize the isAddress terminology, if the aim is for close parity or to minimize confusion errors for devs.
SO answer with additional context.
There was a problem hiding this comment.
Let's handle this in the other refactor #952.
In this particular case, using isAddress doesn't seem suitable because we're dealing with an std.Address object and checking its validity.
Creating a more general method like std.Address{}.IsValid() would be more appropriate in the future. For now, I'll focus on improving the check in the other PR or add a comment for clarification.
Thank you all for your suggestions.
detailed infos are described in #857
TL;DR
foo20relam doesn't check error fromgrc20package.Checklists...
Contributors Checklist
BREAKING CHANGE: xxxmessage was included in the descriptionMaintainers Checklist
CONTRIBUTING.mdBREAKING CHANGE:in the body)